findepi commented on issue #9881:
URL: https://github.com/apache/datafusion/issues/9881#issuecomment-2676375161
`cargo +nightly udeps` has false positives in wasm tests
```
unused dependencies:
`datafusion-wasmtest v45.0.0
(/Users/findepi/repos/datafusion/datafusion/wasmtest)`
└─── dependencies
├─── "datafusion"
├─── "datafusion-execution"
└─── "datafusion-physical-plan"
```
`cargo +nightly udeps --all-targets` has false positives around doc tests
(and the tool reminds of that)
```
unused dependencies:
`datafusion v45.0.0 (/Users/findepi/repos/datafusion/datafusion/core)`
└─── dev-dependencies
└─── "doc-comment"
`datafusion-ffi v45.0.0 (/Users/findepi/repos/datafusion/datafusion/ffi)`
└─── dev-dependencies
└─── "doc-comment"
`datafusion-proto v45.0.0 (/Users/findepi/repos/datafusion/datafusion/proto)`
└─── dev-dependencies
└─── "doc-comment"
`datafusion-proto-common v45.0.0
(/Users/findepi/repos/datafusion/datafusion/proto-common)`
└─── dev-dependencies
└─── "doc-comment"
Note: They might be false-positive.
For example, `cargo-udeps` cannot detect usage of crates that are only
used in doc-tests.
To ignore some dependencies, write
`package.metadata.cargo-udeps.ignore` in Cargo.toml.
```
and for the sysinfo dependency, which i believe is needed for the
`extended_tests`.
```
`datafusion v45.0.0 (/Users/findepi/repos/datafusion/datafusion/core)`
└─── dev-dependencies
├─── "doc-comment"
└─── "sysinfo"
```
to enable udeps on CI we'd need to have these suppressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
