phillipleblanc commented on PR #14783: URL: https://github.com/apache/datafusion/pull/14783#issuecomment-2677510102
> Thank you @cetra3 > > Ideally we would write a test for this., but since I couldn't find any existing tests for data types, I don't think it is strictly necessary here > > Maybe @phillipleblanc has some idea of how to write such a test There are tests at the bottom of this file that can be added - see for example this PR I made for supporting Utf8View: https://github.com/apache/datafusion/pull/13462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org