lovasoa commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967171526
##########
tests/sqlparser_bigquery.rs:
##########
@@ -50,112 +50,146 @@ fn parse_literal_string() {
let select = dialect.verified_only_select(sql);
assert_eq!(12, select.projection.len());
assert_eq!(
- &Expr::Value(Value::SingleQuotedString("single".into())),
+ &Expr::Value(
+ Value::SingleQuotedString("single".into())
+ .with_span(Span::new(Location::new(1, 7), Location::new(1,
12)))
+ ),
Review Comment:
Yes, that would tremendously reduce the amount of work to do in the tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
