zjregee commented on PR #14812: URL: https://github.com/apache/datafusion/pull/14812#issuecomment-2677958302
Hi, @jayzhan211. I'm sorry to bother you again. Before I start replacing other functions, I'd like to get some confirmation from you that my current implementation and handling are as expected. Thanks a lot! https://github.com/apache/datafusion/blob/9ca09cf8f769a3f0a64dbc87ec84eb6fe08b36f6/datafusion/functions/src/string/starts_with.rs#L98-L138 After some experimentation, I ended up not handling the type conversion in `simplify` of `starts_with` for the following reasons: this doesn't seem to cover all failure cases; If args[0] is of type `Expr::Column`, it seems that cannot do a direct type conversion here, because the type of args[0] is not deduced here. The above is my superficial understanding. If there is anything that does not meet expectations, I hope to be corrected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
