ch-sc commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r1967570230
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -1583,6 +1583,17 @@ impl ScalarValue {
}
}
+ /// Returns negation for a boolean scalar value
+ pub fn boolean_negate(&self) -> Result<Self> {
Review Comment:
We can do that, but I think we should then rename `arithmetic_negate` to
just `negate` to cause no ambiguity. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
