alamb opened a new issue, #14879:
URL: https://github.com/apache/datafusion/issues/14879

   ### Is your feature request related to a problem or challenge?
   
   - While working on https://github.com/delta-io/delta-rs/pull/3261 I noticed 
that when a new field is added to 
[`ParserOptions`](https://docs.rs/datafusion/latest/datafusion/sql/planner/struct.ParserOptions.html)
 it requires a downstream API change:
   
   
   ```diff
   ParserOptions {
                           parse_float_as_decimal: 
self.options.parse_float_as_decimal,
                           enable_ident_normalization: 
self.options.enable_ident_normalization,
                           support_varchar_with_length: false,
                           enable_options_value_normalization: false,
   +                        collect_spans: false,
   }
   ```
   
   It would be nice to be able to add new fields to this struct without having 
to make a breaking API change
   
   
   ### Describe the solution you'd like
   
   I would like a builder style API so the above code looks like:
   
   ```rust
   ParserOptions::new()
     .with_parse_float_as_decimal(self.options.parse_float_as_decimal)
     .with_enable_ident_normalization(self.options.enable_ident_normalization)
   ```
   
   Ideally with:
   1. Doc tests showing how to use it
   2. Documentation on all the getters / fields
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   I think this would be a good first issue as it is self contained and well 
specified and would improve the API / UX of datafusion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to