alamb commented on code in PR #14873:
URL: https://github.com/apache/datafusion/pull/14873#discussion_r1970361307


##########
datafusion/core/src/datasource/file_format/mod.rs:
##########
@@ -336,237 +200,29 @@ pub(crate) fn deserialize_stream<'a>(
     .boxed()
 }
 
-/// A container of [FileFormatFactory] which also implements [FileType].
-/// This enables converting a dyn FileFormat to a dyn FileType.
-/// The former trait is a superset of the latter trait, which includes 
execution time
-/// relevant methods. [FileType] is only used in logical planning and only 
implements
-/// the subset of methods required during logical planning.
-#[derive(Debug)]
-pub struct DefaultFileType {

Review Comment:
   it is really nice to see this broken up into smaller modules



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to