alamb opened a new issue, #14913: URL: https://github.com/apache/datafusion/issues/14913
### Is your feature request related to a problem or challenge? - While reviewing https://github.com/apache/datafusion/pull/14821 I noticed that propertes.rs is over 4000 lines of rust and has multiple structures in it https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/equivalence/properties.rs It is hard to navigate and find what is going on ### Describe the solution you'd like I would like to split properties.rs into separate modules. ### Describe alternatives you've considered Something like ``` datafusion/physical-expr/src/equivalence/properties.rs ``` into ``` datafusion/physical-expr/src/equivalence/properties/mod.rs. # contains EquivalencePropertes datafusion/physical-expr/src/equivalence/properties/dependencies.rs. # contains `DependencyMap` and `Dependencies` datafusion/physical-expr/src/equivalence/properties/joins.rs. # contains join_equivalence_properties datafusion/physical-expr/src/equivalence/properties/union.rs. # contains calculate_union ... # any others that are needed ``` And move the relevant tests into the correct module ### Additional context I think this is a pretty mechanical change so flagging it as a good first issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
