LukMRVC commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2688185305
Yes, that's what happening as I mentioned in my [previous comment](https://github.com/apache/datafusion/issues/14448#issuecomment-2685336819). When `ConstEvaluator` is trying to simplify into a scalar, the match expression is matched on `ConstSimplifyResult::SimplifyRuntimeError` making it return `Transformed::yes` variant. https://github.com/apache/datafusion/blob/fc2fbb3d6b3aded73f1b0902168e008e580c89c1/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L521-L541 The comment there explains why for some expressions this is necessary. Maybe this can be improved for actually erroneous cases so that the loop within `simplify_with_cycle_count ` can be exited earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
