geoffreyclaude commented on code in PR #14918:
URL: https://github.com/apache/datafusion/pull/14918#discussion_r1974061938
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -1098,7 +1098,7 @@ impl ListingTable {
)
}))
.await?;
- let file_list = stream::iter(file_list).flatten();
+ let file_list = futures::stream::select_all(file_list);
Review Comment:
Is the following a better alternative? And do we care about ordering here?
```
let meta_fetch_concurrency =
ctx.config_options().execution.meta_fetch_concurrency;
let file_list =
futures::stream::iter(file_list).flatten_unordered(meta_fetch_concurrency);
```
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -1098,7 +1098,7 @@ impl ListingTable {
)
}))
.await?;
- let file_list = stream::iter(file_list).flatten();
+ let file_list = futures::stream::select_all(file_list);
Review Comment:
Is the following a better alternative? And do we care about ordering here?
```rust
let meta_fetch_concurrency =
ctx.config_options().execution.meta_fetch_concurrency;
let file_list =
futures::stream::iter(file_list).flatten_unordered(meta_fetch_concurrency);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
