jayzhan211 commented on code in PR #14917:
URL: https://github.com/apache/datafusion/pull/14917#discussion_r1974552927
##########
datafusion/functions/src/string/contains.rs:
##########
@@ -93,28 +99,51 @@ impl ScalarUDFImpl for ContainsFunc {
/// use `arrow::compute::contains` to do the calculation for contains
pub fn contains(args: &[ArrayRef]) -> Result<ArrayRef, DataFusionError> {
Review Comment:
can change this to private
##########
datafusion/functions/src/string/ends_with.rs:
##########
@@ -103,9 +113,28 @@ impl ScalarUDFImpl for EndsWithFunc {
/// Returns true if string ends with suffix.
/// ends_with('alphabet', 'abet') = 't'
pub fn ends_with(args: &[ArrayRef]) -> Result<ArrayRef> {
Review Comment:
can change this to private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
