alamb commented on code in PR #14938:
URL: https://github.com/apache/datafusion/pull/14938#discussion_r1975608664
##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -1608,24 +1587,18 @@ async fn roundtrip_projection_source() -> Result<()> {
let statistics = Statistics::new_unknown(&schema);
- let source = ParquetSource::default().with_statistics(statistics.clone());
- let scan_config = FileScanConfig {
- object_store_url: ObjectStoreUrl::local_filesystem(),
- file_groups: vec![vec![PartitionedFile::new(
- "/path/to/file.parquet".to_string(),
- 1024,
- )]],
- constraints: Constraints::empty(),
- statistics,
- file_schema: schema.clone(),
- projection: Some(vec![0, 1, 2]),
- limit: None,
- table_partition_cols: vec![],
- output_ordering: vec![],
- file_compression_type: FileCompressionType::UNCOMPRESSED,
- new_lines_in_values: false,
- file_source: source,
- };
+ let file_source =
ParquetSource::default().with_statistics(statistics.clone());
+ let scan_config = FileScanConfig::new(
Review Comment:
I think this also makes the non-default fields more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
