alamb commented on code in PR #14956:
URL: https://github.com/apache/datafusion/pull/14956#discussion_r1976407254
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -266,7 +266,10 @@ impl DataSource for FileScanConfig {
) -> Result<Option<Arc<dyn ExecutionPlan>>> {
// If there is any non-column or alias-carrier expression, Projection
should not be removed.
// This process can be moved into CsvExec, but it would be an overlap
of their responsibility.
- Ok(all_alias_free_columns(projection.expr()).then(|| {
+
+ Ok((all_alias_free_columns(projection.expr())
+ && self.table_partition_cols.is_empty())
Review Comment:
It seems like the check might be if any of the columns needed are in the
table_partition_cols (rather than there just being partition columns at all) 🤔
Or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
