alamb commented on code in PR #14959:
URL: https://github.com/apache/datafusion/pull/14959#discussion_r1976615616
##########
datafusion/catalog-listing/src/helpers.rs:
##########
@@ -103,6 +103,8 @@ pub fn expr_applicable_for_cols(col_names: &[&str], expr:
&Expr) -> bool {
// - AGGREGATE and WINDOW should not end up in filter conditions,
except maybe in some edge cases
// - Can `Wildcard` be considered as a `Literal`?
// - ScalarVariable could be `applicable`, but that would require
access to the context
+ // TODO: remove the next line after `Expr::Wildcard` is removed
+ #[allow(deprecated)]
Review Comment:
I think if you use `expect(deprecated)` here and below rather than
`allow(deprecated)` the compiler will warn / error once we remove
Expr::Wildcard (this is a trick I learned from @itsjunetime )
```suggestion
#[expect(deprecated)]
```
##########
datafusion/expr/src/expr.rs:
##########
@@ -311,6 +311,10 @@ pub enum Expr {
///
/// This expr has to be resolved to a list of columns before translating
logical
/// plan into physical plan.
+ #[deprecated(
+ since = "46.0.0",
+ note = "A wildcard needs to be resolved to concrete expressions when
constructing the logical plan"
Review Comment:
I found a ticket that tracks this work:
- https://github.com/apache/datafusion/issues/7765
```suggestion
note = "A wildcard needs to be resolved to concrete expressions when
constructing the logical plan. See
https://github.com/apache/datafusion/issues/7765";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
