alamb commented on PR #14935: URL: https://github.com/apache/datafusion/pull/14935#issuecomment-2694597493
> > Thank you @irenjj -- I think this makes a lot of sense to me > > > I just wonder if we should provide with_default_features or Default::default implementation for this case as well? wdyt @alamb ? > > > > > > @milenkovicm I think the usecase of not automatically registering all the default features is to allow creating a SessionState _without_ the defaults (e.g. if you don't want to defaults). > > Since there is no method like `SessionStateBuilder::clear` I am not sure how else one would accomplish this usecase 🤔 > > than makes sense, what I suggest is to keep all (new) methods as they are just provide new method which will create new with defaults. but I don't have strong opinion about it - Filed https://github.com/apache/datafusion/issues/14981 to track -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
