alamb commented on code in PR #14990:
URL: https://github.com/apache/datafusion/pull/14990#discussion_r1978177306
##########
.github/workflows/extended.yml:
##########
@@ -28,26 +28,28 @@ concurrency:
#
# We still run them as they provide important coverage to ensure correctness
# in the (very rare) event of a hash failure or sqlite library query failure.
-on:
- push:
+
+# TEMP for testing
+on: [push, pull_request]
+# on:
+# push:
jobs:
# Check crate compiles and base cargo check passes
linux-build-lib:
name: linux build test
runs-on: ubuntu-latest
+ container:
Review Comment:
this makes this job consistent with our other jobs that use the rust
container
##########
.github/workflows/extended.yml:
##########
@@ -28,26 +28,28 @@ concurrency:
#
# We still run them as they provide important coverage to ensure correctness
# in the (very rare) event of a hash failure or sqlite library query failure.
-on:
- push:
+
+# TEMP for testing
+on: [push, pull_request]
+# on:
+# push:
jobs:
# Check crate compiles and base cargo check passes
linux-build-lib:
name: linux build test
runs-on: ubuntu-latest
+ container:
Review Comment:
this makes this job consistent with all the other CI jobs that use the rust
container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
