andygrove commented on code in PR #1471:
URL: https://github.com/apache/datafusion-comet/pull/1471#discussion_r1978309459
##########
spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q1/explain.txt:
##########
@@ -172,12 +172,12 @@ Arguments: [ctr_customer_sk#9, ctr_store_sk#10],
[ctr_customer_sk#9, ctr_store_s
Output [2]: [s_store_sk#24, s_state#25]
Batched: true
Location [not included in comparison]/{warehouse_dir}/store]
-PushedFilters: [IsNotNull(s_state), EqualTo(s_state,TN), IsNotNull(s_store_sk)]
+PushedFilters: [IsNotNull(s_state), IsNotNull(s_store_sk)]
ReadSchema: struct<s_store_sk:int,s_state:string>
(29) CometFilter
Input [2]: [s_store_sk#24, s_state#25]
-Condition : ((isnotnull(s_state#25) AND (s_state#25 = TN)) AND
isnotnull(s_store_sk#24))
+Condition : ((isnotnull(s_state#25) AND (rpad(s_state#25, 2, ) = TN)) AND
isnotnull(s_store_sk#24))
Review Comment:
The `rpad` here is due to changes in Spark starting with 3.5.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
