alamb commented on code in PR #14998:
URL: https://github.com/apache/datafusion/pull/14998#discussion_r1979267227
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -1109,6 +1109,22 @@ impl SessionStateBuilder {
.with_table_function_list(SessionStateDefaults::default_table_functions())
}
+ /// Returns a new [`SessionStateBuilder`] with default features.
+ ///
+ /// This is equivalent to calling [`Self::new()`] followed by
[`Self::with_default_features()`].
+ ///
+ /// ```
+ /// use datafusion::execution::session_state::SessionStateBuilder;
+ ///
+ /// // Create a new SessionState with default features
+ /// let session_state = SessionStateBuilder::new_with_defaults()
+ /// .with_session_id("my_session".to_string())
+ /// .build();
+ /// ```
+ pub fn new_with_defaults() -> Self {
Review Comment:
To keep the name consistent (and make it harder to confuse this with
`default()`) could we please name this `default_features`? Like:
```suggestion
pub fn new_with_default_features() -> Self {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
