wForget commented on code in PR #1462:
URL: https://github.com/apache/datafusion-comet/pull/1462#discussion_r1979412638
##########
spark/src/test/scala/org/apache/spark/CometPluginsSuite.scala:
##########
@@ -143,3 +143,36 @@ class CometPluginsNonOverrideSuite extends CometTestBase {
assert(execMemOverhead4 == "2G")
}
}
+
+class CometPluginsUnifiedModeOverrideSuite extends CometTestBase {
+ override protected def sparkConf: SparkConf = {
+ val conf = new SparkConf()
+ conf.set("spark.driver.memory", "1G")
+ conf.set("spark.executor.memory", "1G")
+ conf.set("spark.executor.memoryOverhead", "1G")
+ conf.set("spark.plugins", "org.apache.spark.CometPlugin")
+ conf.set("spark.comet.enabled", "true")
+ conf.set("spark.memory.offHeap.enabled", "true")
+ conf.set("spark.memory.offHeap.size", "2G")
+ conf.set("spark.comet.exec.shuffle.enabled", "true")
+ conf.set("spark.comet.exec.enabled", "true")
+ conf.set("spark.comet.memory.overhead.factor", "0.5")
+ conf
+ }
+
+ /** Since using unified memory, executor memory should not be overridden */
Review Comment:
> That one should be fine, they passed with current changes to overriding
spark executor memory, but fail without them.
Indeed, I successfully run this test locally, but this comment seems
incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
