alan910127 commented on code in PR #14737: URL: https://github.com/apache/datafusion/pull/14737#discussion_r1981330059
########## datafusion/functions-nested/src/sort.rs: ########## @@ -175,6 +204,7 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result<ArrayRef> { for i in 0..row_count { if list_array.is_null(i) { array_lengths.push(0); + arrays.push(new_null_array(list_array.value(i).data_type(), 1)); Review Comment: oh, thank you so much! I think I did it wrong when dealing with `array_sort(NULL)`. I've pushed a new version, please take a look to check if that's the correct implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org