alamb commented on code in PR #15027:
URL: https://github.com/apache/datafusion/pull/15027#discussion_r1982240264
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -329,19 +311,10 @@ fn optimize_plan_node(
config: &dyn OptimizerConfig,
) -> Result<Transformed<LogicalPlan>> {
if rule.supports_rewrite() {
- return rule.rewrite(plan, config);
+ rule.rewrite(plan, config)
+ } else {
Review Comment:
Actually thinking about this more I think we should simply always call
rule.rewrite now (as it is required to implement now)
I am sorry about this @qazxcdswe123 but could you maybe revert the changes
to OptimizerRule in this PR (and we can work on that in a follow on PR?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
