andygrove commented on PR #1474: URL: https://github.com/apache/datafusion-comet/pull/1474#issuecomment-2704140232
> For example, `CometNativeShuffleSuite::native shuffle: different data type` passes with `COMET_PARQUET_SCAN_IMPL=native_datafusion` on main but fails here. If you dig into the plans, on main we're not actually running the scan in DataFusion. We fall back, though it's not clear why (supporting this PR's necessity). However, with this PR `ParquetExec` shows up in the native plans. I don't have a root cause on the failure, but I'm not sure why we were not letting `ParquetExec` run this test on main. I'll step through plan generation on main and try to make sense of it. Thanks for debugging this. I think I understand the issue now. I will test with `CometNativeShuffleSuite` and push a fix once I have that passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
