irenjj commented on code in PR #15031: URL: https://github.com/apache/datafusion/pull/15031#discussion_r1983653426
########## datafusion/physical-plan/Cargo.toml: ########## @@ -63,6 +63,8 @@ log = { workspace = true } parking_lot = { workspace = true } pin-project-lite = "^0.2.7" tokio = { workspace = true } +unicode-segmentation = "1.10" Review Comment: It is used to detect UTF-8 variable-length characters and prevent them from being truncated. For a single character set, writing the code manually is fine, but if we need to support multiple character sets (UTF-8, UTF8MB4...) in the explain, it's better to introduce a library to handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org