wiedld commented on code in PR #15010:
URL: https://github.com/apache/datafusion/pull/15010#discussion_r1984444530
##########
datafusion/core/tests/physical_optimizer/enforce_distribution.rs:
##########
@@ -2346,42 +2538,33 @@ fn parallelization_multiple_files() -> Result<()> {
let plan =
filter_exec(parquet_exec_multiple_sorted(vec![sort_key.clone()]));
let plan = sort_required_exec_with_req(plan, sort_key);
+ let test_config = TestConfig::new(DoFirst::Distribution)
+ .with_prefer_existing_sort()
+ .with_prefer_repartition_file_scans(1);
+
// The groups must have only contiguous ranges of rows from the same file
// if any group has rows from multiple files, the data is no longer sorted
destroyed
// https://github.com/apache/datafusion/issues/8451
let expected = [
"SortRequiredExec: [a@0 ASC]",
" FilterExec: c@2 = 0",
- " DataSourceExec: file_groups={3 groups: [[x:0..50], [y:0..100],
[x:50..100]]}, projection=[a, b, c, d, e], output_ordering=[a@0 ASC],
file_type=parquet", ];
- let target_partitions = 3;
- let repartition_size = 1;
+ " DataSourceExec: file_groups={3 groups: [[x:0..50], [y:0..100],
[x:50..100]]}, projection=[a, b, c, d, e], output_ordering=[a@0 ASC],
file_type=parquet",
+ ];
assert_optimized!(
expected,
plan,
- true,
- true,
- target_partitions,
- true,
- repartition_size,
- false
+ &test_config.clone().with_query_execution_partitions(3)
Review Comment:
I put the common config a few lines up here:
https://github.com/apache/datafusion/pull/15010/files/5de55b3a8bf1858206dcecc0d3b1907228c970a4#r1984443646.
Then only modified the unique config (`with_query_execution_partitions`) per
test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
