niebayes commented on code in PR #15055:
URL: https://github.com/apache/datafusion/pull/15055#discussion_r1984351304
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -4630,4 +4645,125 @@ digraph {
let parameter_type =
params.clone().get(placeholder_value).unwrap().clone();
assert_eq!(parameter_type, None);
}
+
+ #[test]
+ fn test_join_with_new_exprs() {
Review Comment:
```suggestion
fn test_join_with_new_exprs() -> Result<()> {
```
Make the function fallible so that many `unwrap`'s can be replaced with `?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
