alamb commented on issue #15035: URL: https://github.com/apache/datafusion/issues/15035#issuecomment-2703705299
We have now merged - https://github.com/apache/datafusion/pull/15012 @alan910127 my suggestion on how to start is to write some tests first I would personally suggest following the model of this test: https://github.com/apache/datafusion/blob/da4293323032e2408c9e3b9b28e644a96aea0f13/datafusion/optimizer/src/simplify_expressions/unwrap_cast.rs#L502-L507 And add an expression like `c1 = 'foo'` (c1 is defined [here](https://github.com/apache/datafusion/blob/da4293323032e2408c9e3b9b28e644a96aea0f13/datafusion/optimizer/src/simplify_expressions/unwrap_cast.rs#L773)) ```rust let expr = col("c1").eq(lit("123")) ``` And the expected expression should be that the column is compared to a int32 literal (not a cast on the column): ```rust let expected_expr = col("c1").eq(lit(123i32)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
