suibianwanwank commented on code in PR #15050:
URL: https://github.com/apache/datafusion/pull/15050#discussion_r1985999199
##########
datafusion/optimizer/src/decorrelate.rs:
##########
@@ -56,10 +56,14 @@ pub struct PullUpCorrelatedExpr {
/// Indicates if we encounter any correlated expression that can not be
pulled up
/// above a aggregation without changing the meaning of the query.
can_pull_over_aggregation: bool,
- /// Do we need to handle [the Count bug] during the pull up process.
- /// TODO this parameter should be removed or renamed semantically
+ /// Do we need to handle the [count bug] during the pull up process.
///
- /// [the Count bug]: https://github.com/apache/datafusion/issues/10553
+ /// The "count bug" was described in [Optimization of Nested SQL
Review Comment:
Thank you @comphead @alamb I also made a similar change in
`with_need_handle_count_bug`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
