jayzhan211 commented on code in PR #15090:
URL: https://github.com/apache/datafusion/pull/15090#discussion_r1986038284
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -323,13 +323,6 @@ fn roundtrip_statement_with_dialect() -> Result<()> {
parser_dialect: Box::new(MySqlDialect {}),
unparser_dialect: Box::new(UnparserMySqlDialect {}),
},
- TestStatementWithDialect {
- sql: "select * from (select * from j1 limit 10);",
- expected:
- "SELECT * FROM (SELECT * FROM `j1` LIMIT 10) AS
`derived_limit`",
Review Comment:
If we expand * to all the columns, should we convert back to * for unparser?
I'm not sure should we support this, I delete related test and consider not
supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
