alamb commented on code in PR #15082: URL: https://github.com/apache/datafusion/pull/15082#discussion_r1986051520
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -519,6 +519,150 @@ physical_plan 17)│ format: arrow │ 18)└───────────────────────────┘ + +# Query with projection on csv +query TT +explain SELECT int_col, bigint_col, int_col+bigint_col AS sum_col FROM table1; +---- +logical_plan +01)Projection: table1.int_col, table1.bigint_col, CAST(table1.int_col AS Int64) + table1.bigint_col AS sum_col +02)--TableScan: table1 projection=[int_col, bigint_col] +physical_plan +01)┌───────────────────────────┐ +02)│ ProjectionExec │ +03)│ -------------------- │ +04)│ expr: │ +05)│ [int_col@0 as int_col, │ +06)│ bigint_col@1 as │ +07)│ bigint_col, CAST │ +08)│ (int_col@0 AS Int64) + │ +09)│ bigint_col@1 as sum_col] │ Review Comment: I found this format a bit hard to read as it was all on the same line and word wrapped I wonder if the display would be nicer if we listed each of the expressions on its own line Something like ``` 01)┌───────────────────────────┐ 02)│ ProjectionExec │ 03)│ -------------------- │ 04)│ int_col: int_col@0 │ 06)│ bigint_col: bigint_col@1 │ 06)| sum_col: CAST │ 08)│ (int_col@0 AS Int64) + │ 09)│ bigint_col@1 │ 10)└─────────────┬─────────────┘ ``` I think to that you would need to format each expr above on its own line We can do this as a follow on PR too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
