ctsk commented on code in PR #15044:
URL: https://github.com/apache/datafusion/pull/15044#discussion_r1983234072
##########
datafusion/physical-expr/src/aggregate.rs:
##########
@@ -91,6 +91,9 @@ impl AggregateExprBuilder {
}
}
+ /// Constructs an `AggregateFunctionExpr` from the builder
+ ///
+ /// Note that an [`Self::alias`] must be provided before calling this
method.
Review Comment:
Sounds good :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
