zebsme commented on code in PR #15103:
URL: https://github.com/apache/datafusion/pull/15103#discussion_r1986332402
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -809,8 +809,54 @@ impl DisplayAs for AggregateExec {
}
}
DisplayFormatType::TreeRender => {
- // TODO: collect info
- write!(f, "")?;
+ let g: Vec<String> = if self.group_by.is_single() {
Review Comment:
hi @alamb, sorry for the mistake. Let me clarify my original thoughts. I
noticed that DuckDB provides full expressions for aggregations while only index
for group_by:
```
┌─────────────┴─────────────┐
│ HASH_GROUP_BY │
│ ──────────────────── │
│ Groups: │
│ #0 │
│ #1 │
│ │
│ Aggregates: │
│ sum_no_overflow(#2) │
│ min(#3) │
│ │
│ ~0 Rows │
└─────────────┬─────────────┘
```
But as you pointed out, it lacks test coverage — my apologies, maybe i can
finish it in the future :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
