jonahgao commented on code in PR #15043:
URL: https://github.com/apache/datafusion/pull/15043#discussion_r1986660443
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -455,6 +455,7 @@ pub fn to_substrait_plan(plan: &LogicalPlan, state:
&SessionState) -> Result<Box
relations: plan_rels,
advanced_extensions: None,
expected_type_urls: vec![],
+ parameter_bindings: vec![],
Review Comment:
It's not clear how this is useful compared to directly returning the
replaced logical plan.
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -392,6 +393,14 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
not_impl_err!("Enum expression not supported")
}
+ async fn consume_dynamic_parameter(
+ &self,
+ _expr: &DynamicParameter,
+ _input_schema: &DFSchema,
+ ) -> Result<Expr> {
+ not_impl_err!("Dynamic Parameter expression not supported")
Review Comment:
Decoding it to a placeholder expr may be done as a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
