eliaperantoni commented on issue #14438: URL: https://github.com/apache/datafusion/issues/14438#issuecomment-2710537490
Thank you so much @changsun20 for the incredible work, that's a very nice and comprehensive plan! I think it looks awesome and I definitely like it. Just one minor thing: it seems like there are scalar subqueries and then "in" subqueries. e.g. `SELECT * FROM users WHERE id IN (SELECT id FROM admins)`. Do you think you could easily implement `Diagnostic` for this second case too, in the same PR? It's okay either way, we can also make a separate ticket :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
