Blizzara opened a new pull request, #15130: URL: https://github.com/apache/datafusion/pull/15130
use `return_type_from_args` instead ## Which issue does this PR close? - Closes #14729 ## Rationale for this change Implementing `return_type_from_exprs` is almost harmful, since it's not used by DataFusion for anything. Implementing it instead of `return_type` or `return_type_from_args` leads to code that compiles but fails at runtime. ## What changes are included in this PR? Removes `return_type_from_exprs` completely. This leads to compile failures for anyone who's mistakenly still using it. Also removes `create_physical_expr` command which was using this `return_type_from_exprs`. Given it's also marked as deprecated I didn't check if it could be rewritten to use `return_type_from_args` instead, but if that's possible, we can do it as well to reduce the impact. ## Are these changes tested? Existing tests ## Are there any user-facing changes? Yes, BREAKING CHANGE: ScalarUDFImpl::return_type_from_exprs is removed, also `create_physical_expr` is removed. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
