CrystalZhou0529 commented on code in PR #1055:
URL:
https://github.com/apache/datafusion-python/pull/1055#discussion_r1988370240
##########
python/datafusion/udf.py:
##########
@@ -111,7 +111,27 @@ def __call__(self, *args: Expr) -> Expr:
args_raw = [arg.expr for arg in args]
return Expr(self._udf.__call__(*args_raw))
- class udf:
+ @overload
+ @staticmethod
+ def udf(
+ input_types: list[pa.DataType],
+ return_type: _R,
+ volatility: Volatility | str,
+ name: Optional[str] = None,
+ ) -> Callable[..., ScalarUDF]: ...
+
+ @overload
+ @staticmethod
+ def udf(
+ func: Callable[..., _R],
+ input_types: list[pa.DataType],
+ return_type: _R,
+ volatility: Volatility | str,
+ name: Optional[str] = None,
+ ) -> ScalarUDF: ...
Review Comment:
Thanks for sharing this with me! I wasn't aware of this way to overload a
function in Python but this is so much cleaner than the previous version. I
really appreciate your effort here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
