Blizzara commented on PR #15123: URL: https://github.com/apache/datafusion/pull/15123#issuecomment-2713329924
Yeah, from my perspective this one isn't so bad - implementing any of the deprecated methods is kinda okay, since the defaults are wired to propagate the call correctly here. Calling them is not fine, but as they're marked as deprecated that should be enough to prevent the calls. The other removal (return_type_from_exprs) is more important since there the call chain doesn't work. But then if we do one removal, it might make sense to just do the other one too, to end up with a clean interface.. Up to you guys, I'm happy to have this merged or turn it back into draft and merge later :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
