alamb commented on code in PR #15156:
URL: https://github.com/apache/datafusion/pull/15156#discussion_r1989216255
##########
.github/workflows/rust.yml:
##########
@@ -66,9 +66,12 @@ jobs:
# the changes to `Cargo.lock` after building with the updated
manifest.
cargo check --profile ci --workspace --all-targets --features
integration-tests --locked
- # cargo check common, functions and substrait with no default features
- linux-cargo-check-no-default-features:
- name: cargo check no default features
+ # Check datafusion-common features
+ #
+ # Ensure via `cargo check` that the crate can be built with a
+ # subset of the features packages enabled.
+ linux-datafusion-common-features:
Review Comment:
The diff makes of hard to read but I just moved what jobs each command was
run in -- the overall coverage is the same or better
##########
.github/workflows/rust.yml:
##########
@@ -79,28 +82,63 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- - name: Check datafusion without default features
- # Some of the test binaries require the parquet feature still
- #run: cargo check --all-targets --no-default-features -p datafusion
- run: cargo check --profile ci --no-default-features -p datafusion
-
- - name: Check datafusion-common without default features
+ - name: Check datafusion-common (no-default-features)
run: cargo check --profile ci --all-targets --no-default-features -p
datafusion-common
+ # Note: don't check other feature flags as datafusion-common is not
typically used standalone
- - name: Check datafusion-functions without default features
- run: cargo check --profile ci --all-targets --no-default-features -p
datafusion-functions
-
- - name: Check datafusion-substrait without default features
+ # Check datafusion-substrait features
+ #
+ # Ensure via `cargo check` that the crate can be built with a
+ # subset of the features packages enabled.
+ linux-datafusion-substrait-features:
+ name: cargo check datafusion-substrait features
+ needs: linux-build-lib
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v4
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Check datafusion-substrait (no-default-features)
run: cargo check --profile ci --all-targets --no-default-features -p
datafusion-substrait
+ - name: Check datafusion-substrait (physical)
Review Comment:
this adds coverage of compiling datafusion-substrait with the available
feature flags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
