Jiashu-Hu commented on code in PR #15142:
URL: https://github.com/apache/datafusion/pull/15142#discussion_r1990082244
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -3786,4 +3792,163 @@ Projection: a, b
\n TableScan: test";
assert_optimized_plan_eq(plan, expected_after)
}
+
+ #[test]
+ fn test_push_down_filter_to_user_defined_node() -> Result<()> {
+ // Define a custom user-defined logical node
+ #[derive(Debug, Hash, Eq, PartialEq)]
+ struct TestUserNode {
+ schema: DFSchemaRef,
+ }
+
+ impl PartialOrd for TestUserNode {
+ fn partial_cmp(&self, _other: &Self) -> Option<Ordering> {
+ None
+ }
+ }
+
+ impl TestUserNode {
+ fn new() -> Self {
+ let schema = Arc::new(
+ DFSchema::new_with_metadata(
+ vec![(None, Field::new("a", DataType::Int64,
false).into())],
+ Default::default(),
+ )
+ .unwrap(),
+ );
+
+ Self { schema }
+ }
+ }
+
+ impl UserDefinedLogicalNodeCore for TestUserNode {
+ fn name(&self) -> &str {
+ "test_node"
+ }
+
+ fn inputs(&self) -> Vec<&LogicalPlan> {
+ vec![]
+ }
+
+ fn schema(&self) -> &DFSchemaRef {
+ &self.schema
+ }
+
+ fn expressions(&self) -> Vec<Expr> {
+ vec![]
+ }
+
+ fn fmt_for_explain(&self, f: &mut Formatter) -> std::fmt::Result {
+ write!(f, "TestUserNode")
+ }
+
+ fn with_exprs_and_inputs(
+ &self,
+ exprs: Vec<Expr>,
+ inputs: Vec<LogicalPlan>,
+ ) -> Result<Self> {
+ assert!(exprs.is_empty());
+ assert!(inputs.is_empty());
+ Ok(Self {
+ schema: Arc::clone(&self.schema),
+ })
+ }
+ }
+
+ // Create a node and build a plan with a filter
+ let node = LogicalPlan::Extension(Extension {
+ node: Arc::new(TestUserNode::new()),
+ });
+
+ let plan = LogicalPlanBuilder::from(node).filter(lit(false))?.build()?;
+
+ // Check the original plan format (not part of the test assertions)
+ let expected_before = "Filter: Boolean(false)\
+ \n TestUserNode";
+ assert_eq!(format!("{plan}"), expected_before);
+
+ // Check that the filter is pushed down to the user-defined node
+ let expected_after = "Filter: Boolean(false)\n TestUserNode";
+ assert_optimized_plan_eq(plan, expected_after)
+ }
+
+ #[test]
+ fn test_push_down_filter_to_user_defined_node_2() -> Result<()> {
Review Comment:
Oh, thank you very much for your review! I've removed the second test in the
latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
