changsun20 commented on code in PR #15143: URL: https://github.com/apache/datafusion/pull/15143#discussion_r1990534360
########## datafusion/expr/src/logical_plan/plan.rs: ########## @@ -3617,6 +3620,8 @@ pub struct Subquery { pub subquery: Arc<LogicalPlan>, /// The outer references used in the subquery pub outer_ref_columns: Vec<Expr>, + /// Span information for subquery projection columns + pub spans: Option<Spans>, Review Comment: Got it! It has now been changed to pure `Spans`, and all other places where the `None` placeholder was previously used now use `Spans::new()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org