iffyio commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1992136840
##########
src/ast/mod.rs:
##########
@@ -6148,12 +6218,12 @@ impl fmt::Display for GrantObjects {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
-pub struct Assignment {
+pub struct UpdateAssignment {
Review Comment:
Ah I see, I think its mostly around whether the breaking change is worth it,
doesnt' feel that way in this case, I think it sounds reasonable to introduce
`SetAssignment` but maybe we can keep the `Assignment` as is for now in order
to avoid breaking changes than necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
