alamb commented on code in PR #15166: URL: https://github.com/apache/datafusion/pull/15166#discussion_r1992125689
########## datafusion/physical-plan/src/display.rs: ########## @@ -79,21 +78,6 @@ pub enum DisplayFormatType { TreeRender, } -impl FromStr for DisplayFormatType { Review Comment: This is superceded by the `ExplainFormat` ########## datafusion/sqllogictest/test_files/explain.slt: ########## @@ -434,3 +434,135 @@ drop table t1; statement ok drop table t2; + +## Tests for explain format Review Comment: Here are the tests showing how this works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org