zhuqi-lucas commented on code in PR #15152: URL: https://github.com/apache/datafusion/pull/15152#discussion_r1992824547
########## datafusion/sqllogictest/test_files/aggregates_topk.slt: ########## @@ -19,6 +19,12 @@ # Setup test data table ####### +# Setting to map varchar to utf8view, to test PR https://github.com/apache/datafusion/pull/15152 +# Before the PR, the test case would not work because the Utf8View will not be supported by the TopK aggregation Review Comment: Good point, thank you @alamb. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
