mbutrovich commented on code in PR #1485:
URL: https://github.com/apache/datafusion-comet/pull/1485#discussion_r1993653317
##########
spark/src/test/scala/org/apache/spark/CometPluginsSuite.scala:
##########
@@ -159,23 +159,4 @@ class CometPluginsUnifiedModeOverrideSuite extends
CometTestBase {
conf.set("spark.comet.memory.overhead.factor", "0.5")
conf
}
-
- /*
- * Since using unified memory, but not shuffle unified memory
- * executor memory should be overridden by adding comet shuffle memory size
- */
- test("executor memory overhead is correctly overridden") {
Review Comment:
It's effectively exercising the same path as above now (non-override) but I
could make the values match. I'd argue that it's a redundant test but I can put
it back.
##########
spark/src/test/scala/org/apache/spark/CometPluginsSuite.scala:
##########
@@ -159,23 +159,4 @@ class CometPluginsUnifiedModeOverrideSuite extends
CometTestBase {
conf.set("spark.comet.memory.overhead.factor", "0.5")
conf
}
-
- /*
- * Since using unified memory, but not shuffle unified memory
- * executor memory should be overridden by adding comet shuffle memory size
- */
- test("executor memory overhead is correctly overridden") {
Review Comment:
It's now effectively exercising the same path as above now (non-override)
but I could make the values match. I'd argue that it's a redundant test but I
can put it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
