alamb commented on code in PR #15203:
URL: https://github.com/apache/datafusion/pull/15203#discussion_r1993836149
##########
.github/workflows/rust.yml:
##########
@@ -102,16 +104,21 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
+ - name: Check datafusion-substrait (default features)
+ run: cargo check --profile ci --all-targets -p datafusion-substrait
- name: Check datafusion-substrait (no-default-features)
run: cargo check --profile ci --all-targets --no-default-features -p
datafusion-substrait
+ #
+ # Note: Only check libraries (not --all-targets) to cover end user APIs
Review Comment:
The idea is to test only `--all-targets` for the default features (what a
developer would likely run), otherwise the CI will just verify that a user of
the crate can compile things rather than check all tests and benches too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
