alamb commented on code in PR #15206: URL: https://github.com/apache/datafusion/pull/15206#discussion_r1993919740
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -1711,35 +1711,58 @@ physical_plan query TT explain COPY (VALUES (1, 'foo', 1, '2023-01-01'), (2, 'bar', 2, '2023-01-02'), (3, 'baz', 3, '2023-01-03')) -TO 'test_files/scratch/explain_tree/1.json'; +TO '/tmp/1.json'; Review Comment: Maybe we can save the original path for display - perhaps we could save the `output_url` here as a field on DataSinkConfig 🤔 https://github.com/apache/datafusion/blob/db45ff3eea33c0e3ad607ce1abff266a9956ab22/datafusion/core/src/physical_planner.rs#L500-L499 ```rust FileSinkConfig { ... /// The unresolved URL specified by the user original_url: String ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
