andygrove commented on code in PR #1512:
URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r1993653354
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2734,4 +2734,28 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("test integral divide overflow for decimal") {
+ // decimal support requires Spark 3.4 or later
+ assume(isSpark34Plus)
+ if (isSpark40Plus) {
+ Seq(true, false)
+ } else
+ {
+ // ansi mode only supported in Spark 4.0+
Review Comment:
ANSI mode is supported by all 3.x versions as well, but I think it would be
ok for Comet to only support ANSI mode with Spark 4 since this is the version
that enables it by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
