Omega359 commented on code in PR #13527:
URL: https://github.com/apache/datafusion/pull/13527#discussion_r1993977680


##########
datafusion/core/Cargo.toml:
##########
@@ -144,7 +144,7 @@ zstd = { version = "0.13", optional = true, 
default-features = false }
 
 [dev-dependencies]
 async-trait = { workspace = true }
-criterion = { workspace = true, features = ["async_tokio"] }
+criterion = { workspace = true, features = ["async_tokio", "async_futures"] }

Review Comment:
   This was added so the spm benchmark would run. It's obvious that benchmarks 
are not being run regularly at all which should be looked into.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to