alamb commented on code in PR #1742:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1742#discussion_r1994222582
##########
tests/sqlparser_postgres.rs:
##########
@@ -988,6 +988,7 @@ fn parse_create_schema_if_not_exists() {
Statement::CreateSchema {
if_not_exists: true,
schema_name,
+ ..
Review Comment:
I personally think adding explicit ignores here
```suggestion
options: _,
default_collate_spec: _,
```
Is better as then if a new field is added then the compiler will point out
this place as needing to be checked
That being said, I don't think it is critical in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
