eliaperantoni commented on PR #15209: URL: https://github.com/apache/datafusion/pull/15209#issuecomment-2724283974
@onlyjackfrost > the same data type check in other unary operator. I'm not 100% what you mean by that. For `+` you used the existing error that was returned and added a `Diagnostic` to it. As long as other unary operators already have good error coverage, I think adding `Diagnostic`s to them is perfectly good :) I just hope that all necessary checks already happen in that file, and not "further up" cause that would require more work probably. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
