onlyjackfrost commented on issue #14433:
URL: https://github.com/apache/datafusion/issues/14433#issuecomment-2725209746
@eliaperantoni for the others unary expression.
- `Not`: I didn't see any error that could attach a diagnostic with.
- `Minus`:
- I would like to attach diagnostic with the Datafusion ParserError
"Cannot parse {signed_number} as f64"
- I think we don't have to attach diagnostic to `not_impl_err` right?
There are many `not_impl_err` in the `sql_interval_to_expr` function.
IMO, we only have to handle the Datafusion ParserError "Cannot parse
{signed_number} as f64" for Minus unary expression and add test case for that.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
